Fix Container::UploadObject() not returning Etag and ContentType

rackspace / php-opencloud

The PHP SDK for OpenStack clouds

developer.rackspace.com

Other

451 stars 250 forks source link

Fix Container::UploadObject() not returning Etag and ContentType #684

Open evach-vf opened 8 years ago

evach-vf commented 8 years ago

Container::setContent() is resetting both Etag and ContentType so I moved this call before the Container::populateFromResponse() call in order to get those values from the headers.

Fix issue #683

coveralls commented 8 years ago

Coverage remained the same at 88.818% when pulling bb8a0e81a6cdab1c812e337ec76fac06e04873ad on vanilla:hotfix/pr-uploadObject-etag into 3ffee7b90884a3c556578db8ff9ab2b20b65f18c on rackspace:working.

benms commented 7 years ago

For normal build in TravisCI you can modify composer.json, change version of satooshi/php-coveralls to 1.0 (see commit https://github.com/rackspace/php-opencloud/pull/695/commits/1bcb1d1228f0141d934db07be005bc545d3ed32d).