racoonman2 / TerraBlenderFix

Fixes a performance bug related to TerraBlender’s surface rule api
MIT License
0 stars 0 forks source link

Incompatibility with Nature's Spirit #1

Open Kailgroz opened 1 month ago

Kailgroz commented 1 month ago

nature's spirit biomes are not generated correctly 2024-08-13_04 12 30

racoonman2 commented 1 month ago

I need the world seed and coordinates, because i can't recreate this issue

Kailgroz commented 1 month ago

I need the world seed and coordinates, because i can't recreate this issue

I really don't think it's just this seed since it happens in my modpack in general, I thought it happened because of ReTerraforged but I rarely don't know why it happens, I leave my list of mods if it helps

racoonman2 commented 1 month ago

You sent a link to a file on your pc, I can’t access that. And I still need the seed and coords to properly debug this

Kailgroz commented 1 month ago

mods.txt CustomPreset.json There are the mods and the preset that I am using for reterraforged

Kailgroz commented 1 month ago

2024-08-13_23 06 44 The seed 9211378291487211312 Coordinates X -569 Y 823

racoonman2 commented 1 month ago

what version of regions unexplored are you using?

Kailgroz commented 1 month ago

what version of regions unexplored are you using?

image

racoonman2 commented 1 month ago

I need an example of this happening with only natures spirit installed, because I can't recreate the world you showed in your screenshot even when using your mod list

Kailgroz commented 1 month ago

I need an example of this happening with only natures spirit installed, because I can't recreate the world you showed in your screenshot even when using your mod list

Here is my modpack for curseforge if that helps https://www.mediafire.com/file/mjw7462dqim65e8/Sanctuary.zip/file

iBryguy commented 3 weeks ago

I encountered a similar issue to this, so I had to do some testing. From what I can tell, it's not specifically a Nature's Spirit incompatibility. For some strange reason, TerraBlenderFix is having weird interactions with custom soils/sands in some biomes when certain mod combinations are present.

Here's what I've found so far:

Nature's Spirit and Biomes O' Plenty:

Biomes We've Gone and Mystic's Biomes:

There may be additional biomes that have issues between different mod combinations, but I haven't done a thorough check. These are simply the ones I have noticed so far.

Without knowing the inner workings of TerraBlenderFix, all I can say is that it seems very strange. I suspect there's a specific reason, but I don't know what it is.

ADDENDUM

I thought to quickly check and see if the same issues occurred if Biomes O' Plenty was paired with Biomes We've Gone, and Mystic's Biomes was paired with Nature's Spirit. The previously mentioned surface issues happen with these combinations as well. So it's something related to how Mystic's Biomes and BOP work, and how TerraBlenderFix functions.

iBryguy commented 3 weeks ago

I'm not positive, but I think may have found the issue.

With most biome mods that I'm seeing (e.g. Biomes We've Gone, Regions Unexplored, Nyctophobia, Nature's Spirit), their surface rules target that specific mod's biomes. But Mystic's Biomes and Biomes O' Plenty have surface rules that don't specifically target only their biomes. (For example, Mystic Biome's grassSurface rule, or Biomes O Plenty's grassSurface rule, both of which appear to only care that the rule apply to terrain above water).

When these rules are stored with namespaces, I don't think they're getting applied outside of their respective mod's biomes. But since TerraBlenderFix gets rid of the use of namespaces for surface rules, the generic Biomes O' Plenty and Mystic's Biomes surface rules might then be applied to, and effectively overwriting, other biome mods' surface rules. (Interestingly, this includes Mystic's Biomes overwriting Biomes O' Plenty's surface rules when those two mods are included together)

I can't say for certain that it is the cause, but it would make some sense. It's also the most glaring difference I've seen between BOPs' and Mystic Biomes' surface rules when compared to the surface rules of other mods