search

ractf / shell

A shiny new SPA frontend for the RACTF core.
https://ractf.co.uk/
GNU Affero General Public License v3.0
7 stars 4 forks source link

Performing search with character '#' returns all results #71

Open AtomicMaya opened 2 years ago

AtomicMaya commented 2 years ago

Describe the bug When searching for a user, a team name, etc. performing a search using the search field for any text that includes the pound sign # returns all results.

To Reproduce Steps to reproduce the behavior:

  1. Go to Admin/Teams
  2. Search for #<An existing team name>
  3. See error (all teams in order of registration are displayed)

Expected behavior The results should be only the names containing the characters in the search field.

Screenshots image

Environment (please complete the following information): N/A

thebeanogamer commented 2 years ago

This appears to be a Shell issue. Search strings get truncated at the #, Core is correctly replying to the query.

Searching for asd#asd causes a request to https://api-XXX.ractf.cloud/api/v2/member/?search=asd.

AtomicMaya commented 2 years ago

Can confirm that only first part of string is used.

NicholasG04 commented 2 years ago

We will URL encode this, should fix it probably maybe