search

ractivejs / ractivejs.github.io

https://ractive.js.org
8 stars 33 forks source link

Fix anchored links alignment #139

Closed fskreuz closed 6 years ago

fskreuz commented 6 years ago

Normally, anchored links will scroll to the anchor on arrival. The top menu will naturally obscure this because it's fixed to the top. Margins were added to headers so that it would bump its text below the menu (essentially adding whitespace above the header in the area where the top menu would normally cover).

But this behavior is inconsistent, and linking to an anchor would either land with the header just right in view, a bit higher, or a bit lower than where it should.

simonlayfield commented 6 years ago

Yip - I'm nudging things around in the docs as part of the the brand update so I can certainly take a look at this while I'm at it,

simonlayfield commented 6 years ago

This should be fixed as part of the rebrand merge. Not sure what the etiquette is here as far as closing issues, but it can be reviewed and closed if behaviour is as expected.

fskreuz commented 6 years ago

Looks like it's working. 👍