search

ractivejs / ractivejs.github.io

https://ractive.js.org
8 stars 33 forks source link

Aded css tweaks an inline demo #47

Closed sabob closed 7 years ago

sabob commented 7 years ago

Made the heading font-weight less, changed sidebar colors. Added an intro inline demo.

sabob commented 7 years ago

Use PR if deemed proper, otherwise reject ;-)

fskreuz commented 7 years ago

Was planning to add instructions for Windows last night, but was busy with other things.

We might want platform-specific instructions. IIRC, python and pip for Windows comes in an installer. For ubuntu, it's simply a sudo apt-get install python python-pip. virtualenv can then be installed via pip. Then platform-specific activate and deactivate.

evs-chris commented 7 years ago

I pulled all of the changes except the inline demo over while I was fiddling with the index page. I'll add examples as playground entries and maybe get an inline embeddable version of the playground. Thanks!

sabob commented 7 years ago

Embeddable playground sounds great. What I like about inline demos, is you get instant feedback without breaking context eg. switching to a different view such as playground or jsfiddle

sabob commented 7 years ago

There is a bug in the sidebar, it doesn't set the selected item to active. I think this is a bug in mkdocs though.

evs-chris commented 7 years ago

I noticed that the other day. I'm not sure what changed, but it did work when we first started using mkdocs. I don't see any exceptions, unhandled or otherwise, that seem relevant on page load. I also don't have any experience with the bootstrap thingy that does the scroll spying.

fskreuz commented 7 years ago

I'm working on the layout mentioned in https://github.com/ractivejs/ractivejs.github.io/issues/16. I think the scrollspy handled the boldening of the sidebar items. Not sure what changed. I'm considering using CSS :target for that instead.

sabob commented 7 years ago

Seems the the base.html in custom_theme folder doesn't have the spyscroll enabled. Not sure how that works either.

evs-chris commented 7 years ago

Ah! That actually makes sense. The scroll container is now a div rather than the body, so it's not getting scroll events on the element it is expecting any more. I'll see if there's a way to hook it up on the div.