search

racz16 / WebGL-GLSL-Editor

WebGL GLSL shader editor extension for Visual Studio Code.
Other
100 stars 12 forks source link

Mark `glslangValidatorMac` binary as executable #38

Closed matt-curtis closed 1 year ago

matt-curtis commented 1 year ago

Fixes the issue discussed in #36 by marking the validator binary as executable using chmod +x ..., and committing that into the repo.

racz16 commented 1 year ago

Thank you very much! I'll wait a couple of days if @Nek wants to test it, originally it was his issue #36. But if he doesn't have the time to test it, eventually I'll merge the PR, because seemingly it should work and I'm sure you tested it as well.

Nek commented 1 year ago

@matt-curtis thanks! How do I test it? Should I package the extension from your branch?

matt-curtis commented 1 year ago

@Nek that should work!

racz16 commented 1 year ago

@matt-curtis thanks! How do I test it? Should I package the extension from your branch?

In the repository, you can find the build instructions for Windows and Linux. I think you can loosely follow the Linux instructions on Mac and you don't have to package, it's enough to complete step 10. If you build it on Windows or Linux, you have to package it and copy it to a Mac device.

racz16 commented 1 year ago

@Nek Do you have the time to check the PR? If not it's fine and I'll merge it.

matt-curtis commented 1 year ago

(If Nek can't test and you merge, worst case is that it doesn't work for other macOS users, which doesn't change anything: it doesn't work for macOS users now either.)

Nek commented 1 year ago

@racz16 Sorry, I'm travelling at the moment, no.

racz16 commented 1 year ago

@racz16 Sorry, I'm travelling at the moment, no.

Okay, that's fine, I merge it.