rad-ui / ui

Rad UI is an open-source, headless UI component library for building modern, fast, performant, accessible React applications
http://rad-ui.com
MIT License
11 stars 13 forks source link

Standardize optional params across repository. #170

Open CCleanerShot opened 8 months ago

CCleanerShot commented 8 months ago

As it stands, the project is utilizing 2 different ways to create an optional property:

1)

interface Props { name: string}

const Test = ({name: ''}: Props) {}

2)

interface Props { name?: string}

const Test = ({ name }: Props) {}

Subjective opinion aside, one should be swiftly decided on.

kotAPI commented 8 months ago

We should weigh in the pros and cons, I cannot comment on the difference as I do not know whats happening here, lets discuss this on Discord