rad-ui / ui

Rad UI is an open-source, headless UI component library for building modern, fast, performant, accessible React applications
http://rad-ui.com
MIT License
12 stars 13 forks source link

Fix package version #224

Closed corners2wall closed 8 months ago

corners2wall commented 8 months ago

Closes #195

watermelon-copilot-for-code-review[bot] commented 8 months ago

Watermelon AI Summary

AI Summary deactivated by corners2wall

ui is an open repo and Watermelon will serve it for free. 🍉🫶 Why not invite more people to your team?

coderabbitai[bot] commented 8 months ago

[!IMPORTANT]

Auto Review Skipped

Review was skipped due to path filters

Files ignored due to path filters (2) * `package-lock.json` is excluded by: `!**/*.json` * `package.json` is excluded by: `!**/*.json`

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
kotAPI commented 8 months ago

Hey @corners2wall , we ideally want to lock our versions so when devs install the packages, there are no variations in package versions and won't cause flaky/unexpected behaviors

If these changes have worked, consider updating the package versions to specific versions instead without the ^

Also could you let me know your OS, node, npm versions?

corners2wall commented 8 months ago

@kotAPI in my opinion it's a little bit over work.If you check package.lock famous framework/libraries react, angular ,vue you will see usage ^ in versions

I will try change version to last, but if it's not worked then I suggest use ^

Ubuntu, node v20

kotAPI commented 8 months ago

@kotAPI in my opinion it's a little bit over work.If you check package.lock famous framework/libraries react, angular ,vue you will see usage ^ in versions

I will try change version to last, but if it's not worked then I suggest use ^

Ubuntu, node v20

I see, Things are working fine on my end - I'm on a MacOS with node 22. I've heard it wasnt working on some linux distros for some devs, so its not working as expected everywhere. Need to investigate this more

corners2wall commented 8 months ago

@kotAPI updated, pls check. I can't resolve only one package. It's seems ok

kotAPI commented 8 months ago

@Davidthecode do you want to try this fix?

@corners2wall has been working on it.

Btw if you folks would like to have better communication - you can join the Discord server

corners2wall commented 8 months ago

@kotAPI any update?

kotAPI commented 8 months ago

@kotAPI any update?

I've updated some dependencies this week, you should be able to run dev server without any issues locally. If you are having issues installing packages, you can do npm install --legacy-peer-deps

closing this PR for now, feel free to open it if you were able to fix legacy dependencies