search

rad-ui / ui

Rad UI is an open-source, headless UI component library for building modern, fast, performant, accessible React applications
http://rad-ui.com
MIT License
9 stars 11 forks source link

Accessible Accordion Component #358

Closed kotAPI closed 4 days ago

kotAPI commented 5 days ago

Summary by CodeRabbit

coderabbitai[bot] commented 5 days ago

Walkthrough

The recent changes focus on enhancing the Accordion component's functionality and improving the consistency of styling and context management. Key changes include adding new contexts for accordion items, refactoring the Accordion components to use these contexts, and updating the className handling for various subcomponents. Minor formatting adjustments have also been made to the ToggleGroup component and its related files. Additionally, new styles have been imported for the accordion.

Changes

File Change Summary
src/components/ui/Accordion/Accordion.stories.js Added w-full flex-1 to the className attribute of a div element.
.../AccordionContext.tsx Introduced AccordionContext using createContext from React.
.../AccordionItemContext.tsx Introduced AccordionItemContext using createContext from React.
.../AccordionContent.tsx Updated to use AccordionContext and changed prop customRootClass to className.
.../AccordionHeader.tsx Renamed customHeaderClass prop to className and removed custom class switching logic.
.../AccordionItem.tsx Refactored to use contexts for managing active items and updated class handling.
.../AccordionRoot.tsx Integrated state management for active items using contexts and wrapped children in Provider.
.../AccordionTrigger.tsx Used AccordionContext, updated prop name from customRootClass to className.
.../ToggleGroup.stories.js Formatting changes including adding semicolons and adjusting indentation.
.../ToggleGroup.tsx Added semicolons to import statements and function definitions.
.../ToggleGroup/contexts/toggleContext.tsx Updated import statement for createContext, added semicolons.
styles/themes/default.scss Added an import statement for accordion.scss, affecting styles.

Sequence Diagrams

sequenceDiagram
    participant User
    participant AccordionRoot
    participant AccordionItem
    participant AccordionContext

    User->>AccordionRoot: Load Component
    AccordionRoot->>AccordionContext: Provide activeItem, setActiveItem
    AccordionRoot->>AccordionItem: Render Item
    AccordionItem->>AccordionContext: Consume activeItem
    User->>AccordionItem: Click Item
    AccordionItem->>AccordionContext: Update activeItem
    AccordionContext->>AccordionRoot: Re-render with new activeItem
sequenceDiagram
    participant User
    participant ToggleGroup
    participant ToggleContext

    User->>ToggleGroup: Load Component
    ToggleGroup->>ToggleContext: Create Context
    ToggleGroup->>ToggleGroup: Render Items with Context
    User->>ToggleGroup: Toggle Item
    ToggleGroup->>ToggleContext: Update State
    ToggleContext->>ToggleGroup: Reflect New State

Poem

In the land where components align,
Accordions wrapped in context so fine,
Classes now a breeze,
ToggleGroup in peace,
With styles that truly shine.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.64%. Comparing base (8230c45) to head (37ef389).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #358 +/- ## ======================================= Coverage 94.64% 94.64% ======================================= Files 10 10 Lines 56 56 Branches 9 9 ======================================= Hits 53 53 Misses 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.