search

rad-ui / ui

Rad UI is an open-source, headless UI component library for building modern, fast, performant, accessible React applications
http://rad-ui.com
MIT License
15 stars 18 forks source link

BUG: Tailwind classes of parent element don't get applied to Button #522

Open kuchiPie opened 1 week ago

kuchiPie commented 1 week ago

Description

Bit unsure if it is a bug or an enhancement.

I noticed that tailwind classes don't get applied to the button the way it works on other libraries. The buttons inside the table are not left-aligned even after className="text-right" is applied to it's parent element.

ShadCN: image RadUI: image

Related Tickets & Documents

e.g., Relates to [#4165]

Mobile & Desktop Screenshots/Recordings

If applicable, add screenshots/recordings that show:

kotAPI commented 1 week ago

Thanks for the issue @kuchiPie, currently the display property on the button is set to flex on the button, we'll change it to inline-flex to fix this behavior so it behaves more accurately like a native button

@GoldGroove06, an easy fix if you want to take it up 🥇

GoldGroove06 commented 1 week ago

On to it

kotAPI commented 1 week ago

Fixed in https://github.com/rad-ui/ui/pull/534

should be available once we update the npm package

We're currently working on https://github.com/rad-ui/ui/issues/536 to restore the build pipelines