search

radanalyticsio / openshift-spark

72 stars 83 forks source link

Add a LOCAL_IMAGE var to makefile #2

Closed tmckayus closed 8 years ago

tmckayus commented 8 years ago

This makes it easier to set the local image name so that builds associated with different projects in the same local docker instance can be distinguished, for example myproject/openshift-spark vs yourproject/openshift-spark

elmiko commented 8 years ago

this looks good to me, we probably should start to remove the mattf/openshift-spark stuff at some point.

tmckayus commented 8 years ago

Yeah, we need some kind of placeholder, not sure what it should be.

crobby commented 8 years ago

Seems good, the mattf/openshift-spark bit does seem out of place though.

elmiko commented 8 years ago

i'm guessing we should just merge this and do the other rename in a different PR

crobby commented 8 years ago

Yeah, for sure. Merge away imho