search

radanalyticsio / openshift-spark

72 stars 83 forks source link

Removing hardcoded urls for custom build from CI #20

Closed zak-hassan closed 7 years ago

zak-hassan commented 7 years ago

Using customer build args we can do custom builds 

docker build -t openshift-spark --build-arg DISTRO_LOC=https://dist.apache.org/repos/dist/release/spark/spark-2.1.0/spark-2.1.0-bin-hadoop2.7.tgz --build-arg DISTRO_NAME=spark-2.1.0-bin-hadoop2.7
mattf commented 7 years ago

make sure this continues to build in travis and the autogenerated docker hub build (https://hub.docker.com/r/radanalyticsio/openshift-spark/)

zak-hassan commented 7 years ago

I added a change to .travis.yml to fix that

mattf commented 7 years ago

what about the docker hub autobuilds? maybe you can default the --build-args?

zak-hassan commented 7 years ago

Good point! I'll add a default which is going to be the original url we put in there originally.

mattf commented 7 years ago

ok, be sure to revert the .travis.yml so travis builds essentially the same way docker hub will

zak-hassan commented 7 years ago

Good point. I've reverted and committed.

On Wed, Feb 1, 2017 at 8:23 PM, Matthew Farrellee notifications@github.com wrote:

ok, be sure to revert the .travis.yml so travis builds essentially the same way docker hub will

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/radanalyticsio/openshift-spark/pull/20#issuecomment-276838027, or mute the thread https://github.com/notifications/unsubscribe-auth/ABNf_3cXXdRFUyZ5-XfzbrVfixGCWfUAks5rYTAtgaJpZM4L0M1j .

zak-hassan commented 7 years ago

@mattf I've reverted travis.yml .