Closed zak-hassan closed 7 years ago
make sure this continues to build in travis and the autogenerated docker hub build (https://hub.docker.com/r/radanalyticsio/openshift-spark/)
I added a change to .travis.yml to fix that
what about the docker hub autobuilds? maybe you can default the --build-args?
Good point! I'll add a default which is going to be the original url we put in there originally.
ok, be sure to revert the .travis.yml so travis builds essentially the same way docker hub will
Good point. I've reverted and committed.
On Wed, Feb 1, 2017 at 8:23 PM, Matthew Farrellee notifications@github.com wrote:
ok, be sure to revert the .travis.yml so travis builds essentially the same way docker hub will
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/radanalyticsio/openshift-spark/pull/20#issuecomment-276838027, or mute the thread https://github.com/notifications/unsubscribe-auth/ABNf_3cXXdRFUyZ5-XfzbrVfixGCWfUAks5rYTAtgaJpZM4L0M1j .
@mattf I've reverted travis.yml .
Using customer build args we can do custom builds