radanalyticsio / openshift-spark

72 stars 83 forks source link

Add a Makefile for generating an openshift-spark based on py s2i #3

Closed tmckayus closed 8 years ago

tmckayus commented 8 years ago

The point of this Makefile is to make it easy to generate an openshift-spark image with a python s2i builder image as as base, without having to manually maintain a duplicate docker file. This alternate image has full support for building pyspark applications which can be passed to spark-submit, or python applications that invoke spark-submit, or ...

tmckayus commented 8 years ago

WIP, I need to add a README.md explaining what this does and how to use it.

In a nutshell, it copies the build from the parent (openshift-spark), changes the base image, and makes a new image. It's the best idea I had for keeping the spark version specified in one place but still pulling s2i in as a base (this image in turn will be a base for other images most likely that do something with spark-submit to launch an application).

Note, to have a similar openshfit-spark image with a different builder base (example, java), a sibling directory would be made with a similar (almost identical?) Makefile specifying a java builder base.

tmckayus commented 8 years ago

Now of course there is always the possibility of some kind of complex generator script or image, but this seemed like a simple way to fill the need at present.

tmckayus commented 8 years ago

Oh, I also changed the subdir name to match the image

elmiko commented 8 years ago

lgtm +1