radanalyticsio / openshift-spark

72 stars 83 forks source link

Do not configure cluster for reverse proxy by default. #31

Closed tmckayus closed 7 years ago

tmckayus commented 7 years ago

Due to the issue noted in jira SPARK-20853, this PR removes the logic that enables reverse proxy by default in the openshift-spark image.

tmckayus commented 7 years ago

I tested this by:

1) Building a version of this image (docker.io/tmckay/openshift-spark:noproxy) 2) Launching an oshinko cluster with this image and verifying that reverse proxy was not enabled oshinko create bob --image=docker.io/tmckay/openshift-spark:noproxy 3) Creating a cluster configuration configmap with spark-defaults.conf set to enable reverse proxy on master and workers, then creating another cluster oshinko create jerry --image=docker.io/tmckay/openshift-spark:noproxy --storedconfig=clusterconfig

tmckayus commented 7 years ago

This is a zip file with a script "make_test_configs.sh" that will make a clusterconfig configmap for you. You can alter the spark-defaults.conf file and remake, etc., for testing.

clusterconfigs.zip