search

radanalyticsio / openshift-spark

72 stars 83 forks source link

Updating the python version from 2.7 to 3.6 in Dockerfile #55

Closed LingMQ closed 6 years ago

elmiko commented 6 years ago

@LingMQ thanks for the PR! the output of this looks ok, but we should modify how it is created.

the dockerfile in the build dir is generated by the concreate tool. so we need to modify the yaml and modules that create the dockerfile. also, i think we should keep both the python27 and python36 builds for now just in case someone wants, or expects the 27 stuff.

have a look at my sample change(link below) to see how we could build a module for adding python36 support. the next step will be deciding how we will build both images. maybe keep 2 branches or something? (i'm totally open to suggestions here)

https://github.com/elmiko/openshift-spark/commit/e0edcc31fa81414c67d2bffafc7bb842b98e02e4

elmiko commented 6 years ago

i'm going to close this pull request as #56 will take its place