Closed jkremser closed 5 years ago
i'm curious about
* turn-off the automatic dockerbuilds on docker.io and quay.io
this is because the new approach uses travis for doing the image builds?
this is because the new approach uses travis for doing the image builds?
yes, we can't have both at the same time, it would override the images in the repository. Automated dockerbuilds are easy and quick to setup, but they don't provide the same amount of flexibility as travis+bash combo. It's not possible to run docker-squash for instance, or doing any tag magic.
This looks good to me, but I'm wondering about merge order. Should we do the spark 2.4 change first and make sure everything works before adding this in? And maybe docker and quay builds should be shut off before we merge this -- will the merge cause the travis build to fire?
i think the main timing piece we need to worry about is the image autobuilds that are currently happening. it looked like the 2.4 stuff could happen on either side of this pr.
I am ok w/ waiting for the other PR, however it could be a good oportunity to test the logic that's based on the tags in git.
will the merge cause the travis build to fire
once it's in master, it should trigger the build for the :latest
images (this "if-branch")
@elmiko I fixed that typo you've caught, however the PR still says "elmiko requested changes".
@elmiko I fixed that typo you've caught, however the PR still says "elmiko requested changes".
sorry @Jiri-Kremser , i missed the email when the last change got pushed.
:shipit:
This PR adds a script that for each image that we publish does
docker-squash
for the last 22 layers (23rd is the Centos base image layer) and pushes the image. For each commit to master it runs the same logic to create:latest
images, for tags that matches the "regexp" x.y.z-n, it creates those image tags and also generates thex.y.z-latest
so for instance if the git tag is2.4.0-1
, it will create and push images for:latest
,2.4.0-1
and also2.4-latest
.profit if this is merged: images will be 300 megs smaller
todo:
/cc @elmiko