search

radanalyticsio / openshift-spark

72 stars 83 forks source link

typo in the .travis.release.images.sh #86

Closed jkremser closed 5 years ago

jkremser commented 5 years ago

Fixing the typo in the .travis.release.images.sh dbd5a759e:

[[ c1 -a c2 ]] --> [[ c1 -&& c2 ]]

d7e9cf9bf: With the previous .travis.yml file, the deploy stage was run for each permutation of the matrix. This commit rewrites it from the matrix definition into explicit build stages.

b3ee5c98d: Since the deploy and test stage do not share the same instance on AWS, the previously built docker images are not visible during the deploy stage and they need to be built again (or shared using travis cache, but this brings another set of problems). Building it again is relatively fast.

This is how the build looks like in travis: b8X68nk

https://travis-ci.org/radanalyticsio/openshift-spark/builds/535857574

elmiko commented 5 years ago

lgtm

i think we could write it like

[[ "$TRAVIS_BRANCH" = "master" && "$TRAVIS_PULL_REQUEST" = "false" ]]

but i don't think it matters either way

jkremser commented 5 years ago

~pls, don't merge yet. I'll add also the fix for the travis to run the deploy only once~

^ should be done

jkremser commented 5 years ago

@elmiko please ptal a look :)