search

radanalyticsio / openshift-spark

72 stars 83 forks source link

Change modify-spark behavior for incomplete images and move chmod #97

Closed tmckayus closed 5 years ago

tmckayus commented 5 years ago

The rsync command used to enable the "modify-spark" behavior in incomplete images was preserving permissions. However, it was preserving permissions on files as uploaded by s2i, which can't be relied on (it's not necessarily the same as perms on disk from build_input). Therefore, preserving permissiosn has been dropped, and a chmod to add group rwX to the spark installation was moved until after the rsync.

tmckayus commented 5 years ago

@rimolive @elmiko ptal

rimolive commented 5 years ago

I tested the changes and build is working with permissions fixed. For the propsed changes, everything LGTM.