search

radanalyticsio / oshinko-s2i

This is a place to put s2i images and utilities for spark application builders for openshift
Apache License 2.0
15 stars 27 forks source link

java s2i builder appears to be missing memory limit logic #159

Open sherl0cks opened 6 years ago

sherl0cks commented 6 years ago

The java run scripts seem to be missing the logic for properly setting memory limits, which could cause apps to crash unexpectedly

https://github.com/fabric8io-images/java/blob/master/images/jboss/openjdk8/jdk/container-limits https://developers.redhat.com/blog/2017/03/14/java-inside-docker/

rebeccaSimmonds19 commented 5 years ago

Hi @sherl0cks quick question when you originally put this issue in were you referring to the fabric8 s2i only or all the spark drivers too. This first link is no longer working. thanx for clarification

sherl0cks commented 5 years ago

the fabric8 s2i (which I guess was moved) has the logic in it to properly set memory values. That logic should also live in the spark s2i builders, else they will see the same issues.

On Oct 10 2018, at 5:02 pm, Becky notifications@github.com wrote:

Hi @sherl0cks (https://github.com/sherl0cks) quick question when you originally put this issue in were you referring to the fabric8 s2i only or all the spark drivers too. This first link is no longer working. thanx for clarification — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub (https://github.com/radanalyticsio/oshinko-s2i/issues/159#issuecomment-428583953), or mute the thread (https://github.com/notifications/unsubscribe-auth/ABRfYUUwy0Fz9Z2wWNh_WeTEs3m9kNCAks5ujf3fgaJpZM4REHsI).