search

radanalyticsio / oshinko-s2i

This is a place to put s2i images and utilities for spark application builders for openshift
Apache License 2.0
15 stars 27 forks source link

Issue218 #269

Closed rebeccaSimmonds19 closed 6 years ago

rebeccaSimmonds19 commented 6 years ago

https://github.com/radanalyticsio/oshinko-s2i/issues/218

rebeccaSimmonds19 commented 6 years ago

@crobby this should work on all os it is not specific to macos. Did you try it yourself? Not sure why it has shown the previous macOS changes the only changes to file were change.yaml and the java-build Dockerfile. The Dockerfile now has a new env-var for the spark version. This is changed each time the change.yaml is used to change the spark version.

crobby commented 6 years ago

Question about the Dockerfile change. Any changes to the Dockerfile without a change to the corresponding image.yaml will wind-up being overwritten the next time image.yaml changes (and the Dockerfile is regenerated). Should there be a change to image.java.yaml instead (which will result in the Dockerfile change too)

elmiko commented 6 years ago

just so i understand the change here, if i build this s2i, then make an app from the resulting image i should be able to use the SPARK_VERSION environment variable in my pom file?

rebeccaSimmonds19 commented 6 years ago

yep - fingers crossed!

elmiko commented 6 years ago

this worked for me, here's how i tested it

  1. created an image from this branch with make -f Makefile.java build
  2. pushed image into my openshift project
  3. loaded some hacked templates to use my custom s2i image
  4. ran the jgrafzahl tutorial with this modified pom file

everything worked as expected and i was able to pull the spark version from the environment.

assuming the tests eventually pass, i'm good with this