search

radanalyticsio / oshinko-s2i

This is a place to put s2i images and utilities for spark application builders for openshift
Apache License 2.0
15 stars 27 forks source link

Fix up change-yaml.sh to generate md5 sum for spark #281

Closed tmckayus closed 5 years ago

tmckayus commented 5 years ago

This is transitional while we wait for sha512 support in cekit.

todo[bot] commented 5 years ago

remove this download when sha512 support lands in upstream cekit (tmckay)

https://github.com/radanalyticsio/oshinko-s2i/blob/9deb637bd379e87fbdeeb77fcc08aacbdf60e1f5/change-yaml.sh#L73-L78

This comment was generated by todo based on a TODO comment in 9deb637bd379e87fbdeeb77fcc08aacbdf60e1f5 in #281. cc @tmckayus.
todo[bot] commented 5 years ago

remove this checksum calculation when sha512 support lands in upstream cekit (tmckay)

https://github.com/radanalyticsio/oshinko-s2i/blob/9deb637bd379e87fbdeeb77fcc08aacbdf60e1f5/change-yaml.sh#L93-L98

This comment was generated by todo based on a TODO comment in 9deb637bd379e87fbdeeb77fcc08aacbdf60e1f5 in #281. cc @tmckayus.
todo[bot] commented 5 years ago

replace this with sha512 when it lands in upstream cekit (tmckay)

https://github.com/radanalyticsio/oshinko-s2i/blob/9deb637bd379e87fbdeeb77fcc08aacbdf60e1f5/change-yaml.sh#L113-L118

This comment was generated by todo based on a TODO comment in 9deb637bd379e87fbdeeb77fcc08aacbdf60e1f5 in #281. cc @tmckayus.
tmckayus commented 5 years ago

@elmiko ptal This is part of the in-flight spark 2.4 update

tmckayus commented 5 years ago

is that part of cekit 3? if so we need to modify the image.yamls, we can do that all at once

elmiko commented 5 years ago

looks like my changes are in cekit 3.1 for sure, so maybe we should just proceed as is and leave the todos for later.

tmckayus commented 5 years ago

Merging before tests complete, this is just a utility script