search

radanalyticsio / radanalyticsio.github.io

a developer oriented site for the radanalytics organization
https://radanalytics.io
10 stars 27 forks source link

Copy button 2.0 #269

Closed jkremser closed 5 years ago

elmiko commented 5 years ago

i like the direction this is going, it also looks really nice. but, it is applying to all code blocks i think we need to refine a little bit.

elmiko commented 5 years ago

after talking with Jirka and thinking about this a little, having copy buttons on all the code blocks doesn't seem so bad. i still think we could add something for turning them off, but that could be a followup.

i'd like to get a few more reviews before we merge. @radanalyticsio/radanalytics-io ptal

elmiko commented 5 years ago

@Jiri-Kremser one thing i noticed is that the CONTRIBUTING.md file has a section about adding the copy button, we should remove that as part of this review.

jkremser commented 5 years ago

done + rebased

elmiko commented 5 years ago

thanks for the quick turnaround @Jiri-Kremser, i'd like to get one more approval from someone on @radanalyticsio/radanalytics-io then i'm good to merge.