radanalyticsio / radanalyticsio.github.io

a developer oriented site for the radanalytics organization
https://radanalytics.io
10 stars 27 forks source link

add multiple media links for presentations #278

Closed elmiko closed 5 years ago

elmiko commented 5 years ago

This change adds the feature for having multiple presentation urls in a presentation entry.

changes

elmiko commented 5 years ago

inspired by suggestions in #277

erikerlandson commented 5 years ago

This seems fine to me - is there an easy way to handle two cases: a single url or an array? that would make the pr much smaller

elmiko commented 5 years ago

i'll look into it, although i seem to recall that this didn't work before and putting some sort of type detection logic in the template just seems like overkill

willb commented 5 years ago

In general I can see a case for multiple media attachments but not necessarily to solve this problem. Why not just add the one talk we have with two media links as two “talks” instead of changing the template?

elmiko commented 5 years ago

ok, so it looks like liquid will handle the links properly if we have optional lists

@willb that works too, i'm good either way

elmiko commented 5 years ago

ok, updated so that it doesn't change all the preso. this will allow for option multi-links

erikerlandson commented 5 years ago

LGTM