Add missing executor core limit flag to app deployer

radanalyticsio / spark-operator

Operator for managing the Spark clusters on Kubernetes and OpenShift.

Apache License 2.0

157 stars 61 forks source link

Open sinabakh opened 5 years ago

sinabakh commented 5 years ago

Add missing spark.kubernetes.executor.limit.cores flag to KubernetesAppDeployer.java.

Fix #255

:bug: Bug fix (non-breaking change which fixes an issue)

elmiko commented 5 years ago

this looks reasonable to me, i have not tested it yet though.

jkremser commented 4 years ago

sorry for the late response, the change looks ok. However, travis CI has troubles https://travis-ci.org/radanalyticsio/spark-operator/jobs/596296891#L3102

Could you please try to decrease the number from 400 to 200 here https://github.com/radanalyticsio/spark-operator/blob/master/examples/app.yaml#L16 And let the Travis run the tests?

sinabakh commented 4 years ago

I did as you mentioned but I got no clue why tests fail.

jkremser commented 4 years ago

thanks, I am trying some different numbers to make travis happy, I will let you know