search

radancyco / tb-ajd-template

1 stars 4 forks source link

Update AJD Nav #20

Closed michaelspellacy closed 4 years ago

michaelspellacy commented 5 years ago

Can we make a slight improvement to the AJD navigation and make it nav instead of a div?

You can change label value if you like. The purpose is to differentiate it from main navigation. AT's will read out first link it lands on, like this: "Overview job details", etc.

Thanks!

Brockenstein commented 5 years ago

@michaelspellacy should these also become buttons instead of links?

michaelspellacy commented 5 years ago

@Brockenstein No, even tho we are suppressing normal link behavior here to jump/scroll down to another portion of the page, we a) still want those to be read out as links to AT and b) want them to still work if there is an issue with script on the page.

Brockenstein commented 5 years ago

Thanks I have set aside time next week to tackle this issue

dchacon1 commented 4 years ago

@michaelspellacy This issue has finally been addressed. It will be published when we roll out v2 of the AJD. You can reference https://francis.runmytests.com/job/united-states/account-director-fortune-50-client/1554/15243862

In addition I added aria-label so that it can be distinguished from and existing navigation. CC @Brockenstein