radare / cydia

build system to cross-compile cydia packages for cydia.radare.org
10 stars 2 forks source link

Git package "Depends" field broken: comma missing #1

Closed Thireus closed 7 years ago

Thireus commented 7 years ago

The git package in the repository contains a mistake:

"Depends: expat cacert"

should be instead

"Depends: expat, cacert"

As a result this is what Cydia displays:

git newversion1 from radare repository

W: Problem parsing dependency Depends
W: Error occurred while processing git (NewVersion1)
W: You may want to run apt-get update to correct these problems

The issue is due to a comma that is missing in the package "Depends" field of the git version (2.11.0) of cydia.radare.org. Because of this the package cannot be processed as it should, and is failing to find the package dependencies. The git package isn't listed in the package list of the cydia.radare.org source, however it can be found in the Package.bz archive or via "apt-cache policy git" which should output the following:

  Version table:
     2.11.0 0
 *** 2.8.1-5 0

These lines show that the version "2.8.1-5" is installed (the one from Saurik repository) and that there is a 2.11.0 version (the one from cydia.radare.org repository).

This warning doesn't cause any harm. It just states that the git package from "cydia.radare.org" is broken.

radare commented 7 years ago

uhm https://github.com/radare/cydia/blob/master/packages/git/CONFIG the new pkg doesnt contains this issue. i just removed the 1.7.8 from the repo...

Thireus commented 7 years ago

Ok, I'm still getting the error. Did you push the update?

What's weird is that the package description from github doesn't match the one in the .deb package available in your repo.

radare commented 7 years ago

Yes the pkg should be fine now

On 31 Dec 2016, at 18:28, Thireus ☠ notifications@github.com wrote:

Ok, I'm still getting the error. Did you push the update?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Thireus commented 7 years ago

Still getting the error.

I'm not sure we are talking about the same package. I'm referring to the "git 2.11.0" package available in your repo: http://cydia.radare.org/debs/git_2.11.0_iphoneos-arm.deb

The package is listed on the repo as "git 2.11.0" via http://cydia.radare.org/debs/ (I don't know what you're referring to by "1.7.8" version)

Please see for yourself:

wget http://cydia.radare.org/debs/git_2.11.0_iphoneos-arm.deb
mkdir /tmp/out
dpkg -e git_2.11.0_iphoneos-arm.deb /tmp/out
grep Depends /tmp/out/control

As you can see, the output is:

Depends: expat cacert

While it should be:

Depends: expat, cacert

The comma is missing in the package "Depends" field of the control file. What is even weirder is that this line is completely different from the one that is here on this github repository. So either someone pushed a wrong .deb file by mistake in your repository or there is something fishy in your deployment process.

radare commented 7 years ago

OH damn! you are right :)

for some reason i put the DEPENDS in the makefile instead of the CONFIG file. pls try again :)

https://github.com/radare/cydia/commit/37dcc5abbf8c9be1235ed11545e72f98d86d9a86 https://github.com/radare/cydia/commit/37dcc5abbf8c9be1235ed11545e72f98d86d9a86

and happy new yeah

On 31 Dec 2016, at 22:20, Thireus ☠ notifications@github.com wrote:

Still getting the error.

I'm not sure we are talking about the same package. I'm referring to the "git 2.11.0" package available in your repo: http://cydia.radare.org/debs/git_2.11.0_iphoneos-arm.deb http://cydia.radare.org/debs/git_2.11.0_iphoneos-arm.deb The package is listed on the repo as "git 2.11.0" via http://cydia.radare.org/debs/ http://cydia.radare.org/debs/ (I don't know what you're referring to with "1.7.8" version)

Please see for yourself:

wget http://cydia.radare.org/debs/git_2.11.0_iphoneos-arm.deb mkdir /tmp/out dpkg -e git_2.11.0_iphoneos-arm.deb /tmp/out grep Depends /tmp/out/control As you can see, the output is:

Depends: expat cacert While it should be:

Depends: expat, cacert The comma is missing in the package "Depends" field of the control file. What is even weirder is that this line is completely different from the one that is here on this github repository. So either someone pushed a wrong .deb file by mistake in your repository or there is something fishy in your deployment process.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/radare/cydia/issues/1#issuecomment-269882316, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lhxVnkGh9iUdkdY6FdLqeY8ze2ayks5rNscQgaJpZM4LYVJG.

Thireus commented 7 years ago

No more warnings, issue is fixed! 👍

Thank you. :) And happy new year to you as well!

Thireus commented 7 years ago

FYI, there are other issues now when installing the package.

img_0007

radare commented 7 years ago

uhm try again.. and happy new year ;)

On 31 Dec 2016, at 23:32, Thireus ☠ notifications@github.com wrote:

FYI, there are other issues now when installing the package.

https://cloud.githubusercontent.com/assets/721759/21579469/05b4855a-cfa9-11e6-8bbc-fe7b8f2ad074.jpg — You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/radare/cydia/issues/1#issuecomment-269884228, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lvlUpbSNVQuBBTHMOO3Xb5Kf1u-kks5rNtgGgaJpZM4LYVJG.

Thireus commented 7 years ago

All good thanks. Happy new year!

ada1016 commented 7 years ago

Steven6:~ root# git -sh: /usr/bin/git: Bad CPU type in executable

any hint? please?

ada1016 commented 7 years ago

By the way it is iOS 9.3.3 JB device

radare commented 7 years ago

32 or 64?

On 24 May 2017, at 08:32, ada1016 notifications@github.com wrote:

By the way it is iOS 9.3.3 JB device

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

ada1016 commented 7 years ago

64, thanks

radare commented 7 years ago

it should be good now

On 31 May 2017, at 11:25, ada1016 notifications@github.com wrote:

64, thanks

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/radare/cydia/issues/1#issuecomment-305135883, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lpzCHuzXJ7uiOrRkIE0BPZft0UE9ks5r_THxgaJpZM4LYVJG.