Closed FetheredSerpent closed 10 months ago
😍
Missed these earlier
Sorry for the slow interactions from my side. Im afk but im really excited for this pr! I'll check it out and merge tonight! Thank you <3
is the final dist shipping all the r2 and qt libs? so it works out of the blue or still requires moving the dlls by hand?
Every needed dll from r2 and Qt is included, which makes it work automagically out of the box (iaito.zip in artifacts) on my system. MSVCRT dlls are are not included, but there is an installer to it (included, ✌️ ).
Haven't actually tested it thoroughly, so might be missing something.
Sweet! Ideally this msvcrt may be shipped too. I dont expect users to use an instaler or have vs installed. But i guess the installer approach is the less anoying one
Merging! thank you! if there's any other improvement you see make a separate PR!
macos and linux deploy also need similar care, but i'll try your changes too! hope to get that stuff in the release CI when r2-5.9 is out
Anything specific like build/runtime errors, or generic build system changes?
The problems is the release zip. Macdepkoy doesnt seem to ship the qt libs and r2 is not copied. Dmg not created, no icon, etc. but it builds and runs fine
Checklist
Description
Updated preconfigure.bat, configure.bat and make.bat to deploy iaito for Windows. Also removed some repetition in ci.yml and preconfigure.bat.