radareorg / iaito

Official QT frontend of radare2
GNU General Public License v3.0
1.05k stars 88 forks source link

Debian release packages lack dependency information #142

Closed GravisZro closed 1 year ago

GravisZro commented 1 year ago

Description

I install the latest release and everything seemed to work. Later I started it up again and it threw a segmentation fault. After reinstalling the package and no progress, I checked the dependencies and found it had none listed at all. This is obviously a problem as I seemed to have upgraded some packages and now iaito is non-functional.

Here is the current package info:

~$ dpkg --info ~/Downloads/iaito_5.8.8_amd64.deb 
 new Debian package, version 2.0.
 size 1298444 bytes: control archive=1028 bytes.
     288 bytes,     9 lines      control
    1941 bytes,    26 lines      md5sums
 Package: iaito
 Version: 5.8.8
 Section: editors
 Priority: optional
 Architecture: amd64
 Installed-Size: 6032
 Maintainer: pancake <pancake@nopcode.org>
 Description: QT frontend for radare2
  This is the continuation of Iaito after the project forked out so it keeps using radare2 as backend.

A proper package would have "Depends" information like this:

Depends: libc6 (>= 2.4), libgcc-s1 (>= 3.0), libqt5core5a (>= 5.15.1), libqt5gui5 (>= 5.12.2) | libqt5gui5-gles (>= 5.12.2), libqt5svg5 (>= 5.6.0~beta), libqt5widgets5 (>= 5.12.2), libstdc++6 (>= 5)
GravisZro commented 1 year ago

These should be in your dependency list:

radare2 libqt5core5a libqt5gui5 libqt5widgets5 libqt5network5 libqt5svg5

Note that you will need to determine version numbers as well.

trufae commented 1 year ago

Can you update the CONFIG file from dist/debian with your suggested changee?

GravisZro commented 1 year ago

@trufae to do that, you need to have the package versions of the system it's built on. I added a script that is called from CONFIG that should generated the dependency list with the version numbers.

trufae commented 1 year ago

Can we close this ticket after merging your pr? I can upload the new deb for testing. Thank you!

GravisZro commented 1 year ago

If you make a new release or update the previous release and it has the dependencies in the package, then yeah. I'm concerned they may not be included at all.

trufae commented 1 year ago

Done https://github.com/radareorg/iaito/releases/tag/5.8.8

trufae commented 1 year ago

let's wait for some testing and feedback before closing the ticket. thanks

GravisZro commented 1 year ago

Unfortunately, it didn't work. I'm looking into the build system because it appears the variable isn't being defined in the makefile.

GravisZro commented 1 year ago

OK, so I tracked down the issue and definitively fixed it. Merge the PR, update the deb package, and you can close this issue.

GravisZro commented 1 year ago

I made a similar fix for radare itself: https://github.com/radareorg/radare2/pull/22280