Fix release CI failing on macOS artifact upload

radareorg / iaito

Official QT frontend of radare2

GNU General Public License v3.0

968 stars 83 forks source link

Fix release CI failing on macOS artifact upload #143

Closed FetheredSerpent closed 10 months ago

FetheredSerpent commented 10 months ago

Checklist

[ ] Closing issues: #issue
[ ] Mark this if you consider it ready to merge
[ ] I've added tests (optional)
[ ] I wrote some documentation

Description

Changed path where CI was looking for macOS artifact, should now find them during a release. Also, fixed the Windows artifact having 'macos' in it's name.

FetheredSerpent commented 10 months ago

I don't have a mac so I couldn't check the icon and bundling issue, but the .dmg generated in CI artifact seems to include the r2 .dylib(s) and Qt is included as Private Framework, which seems to be the default for macdeployqt. It would be nice if someone could test it.

trufae commented 10 months ago

Merged! I'll try it now!