search

radareorg / iaito

Official QT frontend of radare2
GNU General Public License v3.0
968 stars 83 forks source link

Makefile ignores `-j` on Linux #151

Closed jjdredd closed 5 months ago

trufae commented 7 months ago

because its running qmake under the hood?

jjdredd commented 7 months ago

I found that it has been hard-coded into the Makefile in the iaito target. I believe the makefile has been generated by the configure script It's actually here https://github.com/radareorg/iaito/blob/master/Makefile#L66 Also, I don't think qmake controls the number of jobs.

trufae commented 7 months ago

The configure script doesnt generate any makefile. Feel free to remove that -j4 and see if the makejobs/makeflags is propagated properly and make a pr. Thanks!

jjdredd commented 7 months ago

I've tested changing the jobs number in the line I mentioned and it worked as intended.

trufae commented 7 months ago

So make a pr

jjdredd commented 5 months ago

fixed in https://github.com/radareorg/iaito/commit/c3409ab2517b593c0c1eb0c98583984309695c5c