Ticket#174/Keep the logic thru skipOptionsDialog

mikelloc commented 3 weeks ago

This PR is the fix for the https://github.com/radareorg/iaito/issues/174

Checklist

[ ] Closing issues: #issue
[ ] Mark this if you consider it ready to merge
[ ] I've added tests (optional)
[ ] I wrote some documentation

Description

The approach followed here is to keep propagating the checkBox_FilelessOpen value to setupAndStartAnalysis (passing thru openNewFile and displayInitialOptionsDialog). The idea is to avoid setting any file name nor loading it while maintaining as much as existing logic and program flow as possible. I think a cleaner approach can be done (in a following PR) checking it earlier and jump to finalizeOpen. More about this on this other PR, merge only one of them and close the other.

trufae commented 3 weeks ago

I liked more the cleaner version

mikelloc commented 3 weeks ago

I liked more the cleaner version

Me too! I just prepared this in case that following all the flow was preferred, let's close this one then :)

radareorg / iaito

Ticket#174/Keep the logic thru skipOptionsDialog #176