search

radareorg / ideas

4 stars 1 forks source link

rabin2: symbol postprocessing #240

Open radare opened 9 years ago

radare commented 9 years ago

Symbol postprocessing

radare commented 7 years ago

Solvable with Sdb, after the update-sdb merge. but needs refactoring of all the bin plugins

XVilka commented 5 years ago

@radare @ret2libc what do you think about this one?

ret2libc commented 5 years ago

What is this issue about exactly? We already demangle symbols and avoid dups (unless there are bugs in the bin plugins like in ELF right now)

radare commented 5 years ago

the issue is that we are doing this in a not very efficient way because multiple lists are created and filtered and iterated when we could just hook a function and update a hashtable just when the plugins emits a new symbol for example

On 16 Nov 2018, at 10:16, Riccardo Schirone notifications@github.com wrote:

What is this issue about exactly? We already demangle symbols and avoid dups (unless there are bugs in the bin plugins like in ELF right now)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/radare/radare2/issues/2211#issuecomment-439330523, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-ltdp_SQqajWmGj5pv5V-ELZHGHtVks5uvoJggaJpZM4DxdNM.

ret2libc commented 4 years ago

I'm not sure this is relevant any more. Can we explain what is exactly the issue or close it, since there are of course always functions to improve and stuff, I'm not sure this is really helpful.

trufae commented 4 years ago

Give me some time to craft a binary to show you the need for this

trufae commented 4 years ago

feel free to move this issue to ideas because it requires more discussion and work to get it in