search

radareorg / ideas

4 stars 1 forks source link

Merge z80, 8080 and gb with e asm.cpu #259

Open radare opened 7 years ago

radare commented 7 years ago

z80 and gb have a very similar CPU, we should share code, or at least make z80 at the same state of the gb one, because anal, and disasm fails a lot with -a z80, and the same goes for the assembler

Maijin commented 7 years ago

e asm.cpu

radare commented 7 years ago

Im all for asm.cpu

On 1 Aug 2017, at 15:51, Maijin notifications@github.com wrote:

or even e asm.cpu *

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

XVilka commented 7 years ago

asm.cpu++

condret commented 7 years ago

asm.cpu, but we need a field for it in rbin. I don't want to set it by hand every time. Btw, we could merge z80,8080 and gb here

radare commented 7 years ago

yep

On 17 Aug 2017, at 20:17, condret notifications@github.com wrote:

asm.cpu, but we need a field for it in rbin. I don't want to set it by hand every time. Btw, we could merge z80,8080 and gb here

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/radare/radare2/issues/8088#issuecomment-323152956, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-ln6CiHt9XAWZ832GT4spTNWo0tdFks5sZIO0gaJpZM4OpqCJ.

Maijin commented 6 years ago

@condret it's done now https://github.com/radare/radare2/commit/4427537998bac1914422121ae7424f780bd07c22