search

radareorg / ideas

4 stars 1 forks source link

Add "Warning this file has changed" like in vim #261

Open radare opened 7 years ago

radare commented 7 years ago

When the timestamp of any opened file changes we may want to warn the user and query him to know if he wants to reload or not.

This may be anoying, break r2pipe, so maybe we can just show the warning. thep roblem is that checking if timestamp of the file has changed is a slow operation that we dont want to run on every loop. Maybe the solution goes to add a command under 'o' to check if the file has changed from what we have loaded in IO now and show if it has changed or not.

users can set this command in cmd.prompt and use ?? to show a yesno to reload or not. in just pure r2scripting

crowell commented 7 years ago

what about handlers for inotify/fsevents/FindFirstChangeNotification instead of polling?

radare commented 7 years ago

It was in my plans to add a fsmon api in r2.. but fsmon code is not precisely simple, not sure if it really matters if we can just stat.. but stat on every prompt is slow

On 19 Nov 2017, at 16:57, Jeffrey Crowell notifications@github.com wrote:

what about handlers for inotify/fsevents/FindFirstChangeNotification instead of polling?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

radare commented 6 years ago

i think we can solve this issue by adding a new command under 'o' that checks if the current selected file (or specified by arg) has changed comparing it when it was loaded. So we may probably want to add a timestamp information in RIO? any comments in here @ret2libc @condret

radare commented 6 years ago

cc @rlaemmert