Improve disassembly reflines

[radare]

• [ ] Avoid overlapping edges (requires 2nd pass) (slower, so optional)
• [x] Colorize forward/backward lines
• [ ] Use different color for each line (rainbow)
• [ ] avoid loops over reflines for each call to r_anal_reflines_str (see comments in r_anal_reflines_get on how to do it)
• [x] backward edges should stay on external layers
• [x] fcnline disappears with comments https://github.com/radare/radare2/issues/3666

[jjdredd]

This may require major refactoring...

[radare]

@jjdredd this major refactoring has been done by @ret2libc in his last PR ;)

[XVilka]

Related are https://github.com/radare/radare2/issues/2545 and https://github.com/radare/radare2/issues/3259 and https://github.com/radare/radare2/issues/3611

[XVilka]

How to handle this case?

             ┌─< f000:5cde    e300           jcxz 0xf5ce0              ;[6]                                                                                               
            ┌└─> f000:5ce0    e300           jcxz 0xf5ce2              ;[7]                                                                                               
            └──> f000:5ce2    ee             out dx, al                                                                                                                   
             ┌─< f000:5ce3    e300           jcxz 0xf5ce5              ;[8]                                                                                               
            ┌└─> f000:5ce5    e300           jcxz 0xf5ce7              ;[9]                                                                                               
            └──> f000:5ce7    8cd8           mov ax, ds                    

When the beginning of the one refline is also an end of the another? How to show them properly?

[XVilka]

@ret2libc you maybe want to check this one?

[ret2libc]

I'd rather focus on other stuff at the moment (e.g. projects, analysis, etc.)

[ret2libc]

This issue has been moved from radareorg/radare2 to radareorg/ideas as we are trying to clean our backlog and this issue has probably been created a long while ago. This is an effort to help contributors understand what are the actionable items they can work on, prioritize issues better and help users find active/duplicated issues more easily. If this is not an enhancement/improvement/general idea but a bug, feel free to ask for re-transfer to main repo. Thanks for your understanding and contribution with this issue.