radareorg / r2ai

local language model for radare2
https://www.radare.org
MIT License
104 stars 17 forks source link

Remove bind ^I rl_complete for macos #79

Closed dnakov closed 1 month ago

dnakov commented 1 month ago

Checklist

Description

tab works now, can type b. (Sequoia 15.1). Reject if this breaks it on your mac.

trufae commented 1 month ago

In my case this makes do nothing on macOS

dnakov commented 1 month ago

Just tried it on another mac, tab works fine with this PR, no "b", no tab on master

$ python3 -c "import readline; print(readline.__doc__)"
Importing this module enables command line editing using GNU readline.

$ sw_vers
ProductName:        macOS
ProductVersion:     14.5
BuildVersion:       23F79
trufae commented 1 month ago

in my case i got this:

$ python3 -c "import readline; print(readline.__doc__)"
Importing this module enables command line editing using libedit readline.
$ sw_vers
ProductName:        macOS
ProductVersion:     15.0.1
BuildVersion:       24A348

guess its time for another if

trufae commented 1 month ago

i think we can close this PR now, please confirm on master