search

radareorg / r2pipe.rs

Rust crate for r2pipe
Other
45 stars 19 forks source link

Drop rustc-serialize dependency #19

Closed dtolnay closed 7 years ago

dtolnay commented 7 years ago

We were hoping to drop the rustc-serialize dependency in https://github.com/resetnow/xtensa2arm/issues/1 because it is deprecated, but can't because of this library. Any plans to replace rustc-serialize with a different library?

radare commented 7 years ago

Not for me, but makes sense to reduce or drop dependencies. Any suggestion? Feel free to send a pr if you have any proposal/patch

On 18 May 2017, at 08:23, David Tolnay notifications@github.com wrote:

We were hoping to drop the rustc-serialize dependency in resetnow/xtensa2arm#1 because it is deprecated, but can't because of this library. Any plans to replace rustc-serialize with a different library?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

dtolnay commented 7 years ago

For JSON I would definitely recommend Serde. Is it being used for anything else?

radare commented 7 years ago

R2pipe.rs is used by radeco and rune iirc but you can break them if its for good

On 18 May 2017, at 17:00, David Tolnay notifications@github.com wrote:

For JSON I would definitely recommend Serde. Is it being used for anything else?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

jrozner commented 7 years ago

Just submitted a pull request that does this. Take a look at #20

radare commented 7 years ago

it was merged

On 9 Jun 2017, at 23:34, Joe Rozner notifications@github.com wrote:

Just submitted a pull request that does this. Take a look at #20 https://github.com/radare/r2pipe.rs/pull/20 — You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/radare/r2pipe.rs/issues/19#issuecomment-307505363, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lt_UoeD2VjjzIDigzZnuv_xUCxGmks5sCbqBgaJpZM4NeyDc.

jrozner commented 7 years ago

This needs to be manually closed because I didn't add one of the keywords into the commit message unfortunately.