radareorg / r2pipe.rs

Rust crate for r2pipe
Other
45 stars 19 forks source link

Removes higher level API functions from r2pipe.rs #23

Closed chinmaydd closed 7 years ago

chinmaydd commented 7 years ago

This is a API breaking change.

Bumps r2pipe to 0.5.0.

TODO:

This functionality is to be moved to a newer repository. This is in-line with the discussion here. Multiple projects require wrappers around certain specific r2 features and pancake deemed it necessary to separate the core pipe-based logic and higher level constructs into a different project.

This PR will be updated with links to PRs to other r2-based dependent repositories.

@radare have a look. This should only be merged when all of the above projects have been stabilized to use the newer API.

radare commented 7 years ago

do you prefer radare2-r2pipe-api/rust repository or just put the stuff inside radare2-r2pipe/api/rust/…

On 10 Jul 2017, at 19:32, Chinmay Deshpande notifications@github.com wrote:

This is a API breaking change.

Moves r2pipe to 0.5.0.

TODO:

Add README notice Bump version Creation of the r2pipe.rs-frontend(tentative) repository Stable version of the crate on Cargo libsmt.rs radeco radeco-lib rune esil-rs This functionality is to be moved to a newer repository. This is in-line with the discussion here https://github.com/radare/r2pipe.rs/pull/18. Multiple projects require wrappers around certain specific r2 features and pancake deemed it necessary to separate the core pipe-based logic and higher level constructs into a different project.

This PR will be updated with links to PRs to other r2-based dependent repositories.

@radare https://github.com/radare have a look. This should only be merged when all of the above projects have been stabilized to use the newer API.

You can view, comment on, or merge this pull request online at:

https://github.com/radare/r2pipe.rs/pull/23 https://github.com/radare/r2pipe.rs/pull/23 Commit Summary

This aims to make the following changes: File Changes

M src/lib.rs https://github.com/radare/r2pipe.rs/pull/23/files#diff-0 (5) M src/r2.rs https://github.com/radare/r2pipe.rs/pull/23/files#diff-1 (142) D src/structs.rs https://github.com/radare/r2pipe.rs/pull/23/files#diff-2 (127) Patch Links:

https://github.com/radare/r2pipe.rs/pull/23.patch https://github.com/radare/r2pipe.rs/pull/23.patch https://github.com/radare/r2pipe.rs/pull/23.diff https://github.com/radare/r2pipe.rs/pull/23.diff — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/radare/r2pipe.rs/pull/23, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-ljnitC8lX7seSBEpewJjqtorXNK1ks5sMmArgaJpZM4OTKiw.

chinmaydd commented 7 years ago

I think either is fine. To keep up with the convention and abstain from creating additional repositories, I think adding it as folder under the name "rust" is just fine. Although, we might need to setup the test framework accordingly for each API folder.

radare commented 7 years ago

the repo was created, see radare2-r2pipe-api

i think it makes sense to put it in a separate place to add proper discussion about this in there and not mess the issues with r2pipe.

On 11 Jul 2017, at 19:20, Chinmay Deshpande notifications@github.com wrote:

I think either is fine. To keep up with the convention and abstain from creating additional repositories, I think adding it as folder under the name "rust" is just fine. Although, we might need to setup the test framework accordingly for each API folder.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/radare/r2pipe.rs/pull/23#issuecomment-314513415, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-loVQJcGOjI-quTh3EIlF3lMuXV01ks5sM67mgaJpZM4OTKiw.

chinmaydd commented 7 years ago

@radare, I think you can merge this PR and then have look over at radeco-lib and merge that as well.

radare commented 7 years ago

Done!

On 15 Jul 2017, at 19:56, Chinmay Deshpande notifications@github.com wrote:

@radare, I think you can merge this PR and then have look over at radeco-lib and merge that as well.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.