add callback support in async api

radareorg / r2pipe.rs

Rust crate for r2pipe

Other

45 stars 19 forks source link

add callback support in async api #30

Closed xermicus closed 5 years ago

xermicus commented 6 years ago

Addition to #29: Now supports callbacks Ping #7 and #21

XVilka commented 6 years ago

@kriw @HMPerson1 @chinmaydd can you please check this one?

chinmaydd commented 6 years ago

This looks great! @xermicus :smile:

Can you add a line or two of documentation for the R2Pipe::threads function highlighting the async API changes? Specifically that the callback function takes in thread_id as u16, r2pipe output as String as arguments (just for bookkeeping)

EDIT: Or we can your example to lib.rs. Anything works.

xermicus commented 6 years ago

thanks @chinmaydd ! Sure, actually I was considering to update/extend the whole doc a bit soon (TM). I can include that into this PR as well

XVilka commented 5 years ago

@xermicus ping?

xermicus commented 5 years ago

pong - tried to add little documentation