search

radareorg / r2pipe.rs

Rust crate for r2pipe
Other
45 stars 19 forks source link

Update README.md #35

Closed xermicus closed 4 years ago

xermicus commented 4 years ago

Some more love for this crate

Detailed description

...

Test plan

...

Closing issues

...

xermicus commented 4 years ago

@XVilka Suppose I need to implement an async/await interface. Would you prefer to keep it inside this repository (+ only one repo, - dependencies will blow up somewhat). The other option would be to create a new dedicated async-r2pipe crate (+user that don't care about async can use native crate, - one more repo for someone to maintain). ?

XVilka commented 4 years ago

It can be feature-guarded, depending on how many changes in the code that would require. I skimmed through the code today, should not be a big problem.

On Sat, Jun 13, 2020, 01:06 Cyrill Leutwiler notifications@github.com wrote:

@XVilka https://github.com/XVilka Suppose I need to implement an async/await interface. Would you prefer to keep it inside this repository (+ only one repo, - dependencies will blow up somewhat). The other option would be to create a new dedicated async-r2pipe crate (+user that don't care about async can use native crate, - one more repo for someone to maintain). ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/radareorg/r2pipe.rs/pull/35#issuecomment-643387249, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABRT7NZSHB2XUJA2BOV47TRWJOAJANCNFSM4N4PX65A .

xermicus commented 4 years ago

Yes that should be doable :+1: