search

radareorg / r2pipe.rs

Rust crate for r2pipe
Other
45 stars 19 forks source link

Add clippy and fmt to CI #38

Closed meme closed 3 years ago

meme commented 3 years ago

Detailed description

Make CI more extensive. Ensure code is formatted and follows clippy code guidelines. Also fix existing clippy warnings

Test plan

Run the CI, run cargo clippy, cargo fmt locally.

Closing issues

N/A

trufae commented 3 years ago

The CI seems unhappy in here https://github.com/radareorg/r2pipe.rs/pull/38/checks?check_run_id=2589357742

meme commented 3 years ago

Resolved. Thanks.

trufae commented 3 years ago

Still red. Not sure what this diff is trying to tell us. But i guess moving those two lines is what rust expects