radareorg / r2pipe.rs

Rust crate for r2pipe
Other
45 stars 19 forks source link

Properly close R2Pipe child proc #40

Closed xermicus closed 3 years ago

xermicus commented 3 years ago

Detailed description

Wait for the child proc after closing the r2pipe to free resources. Without this fix the child process is not properly closed on a call to close().I experience this when spawing lot of pipes.

This seems to match the docs:

On some systems, calling wait or similar is necessary for the OS to release resources. ... The standard library does not automatically wait on child processes (not even if the Child is dropped),

...

Test plan

...

Closing issues

...

meme commented 3 years ago

Thanks!