Take care of the repeated match statements in the impl R2Pipe block

RHL120 commented 1 year ago

Checklist

[ ] Closing issues: #issue
[x] Mark this if you consider it ready to merge
[ ] I've added tests (optional)
[ ] I wrote some documentation

Description I was browsing the r2pipe.rs code when I noticed a repeated match statement in cmd, cmdj and close. I thought that since the methods are the same that we could put them in a trait and have a method that does all the matching. I have tested it with main.rs. The result is only a 10 line reduction so I don't know if this is a helpful change considering the added complexity.

RHL120 commented 1 year ago

LGTM. Please make sure cargo fmt and cargo clippy are all passed so CI passes.

Done!

RHL120 commented 1 year ago

Hello again. It seems like you approved the PR but you did not merge it. Is there anything wrong, anything I could do?

radareorg / r2pipe.rs

Take care of the repeated match statements in the impl R2Pipe block #44