Closed thestr4ng3r closed 6 years ago
This doesnt solves the windows compat at all. Changing the format of the packages is not an issue imho. Parsing current shellscript is easy
The problem is that we need to build or support binary builds. Imho windows crap should just work with binary builds. Or use standard installation procedures to not depend on make or other unix tools
On 27 Jun 2018, at 12:48, Florian Märkl notifications@github.com wrote:
Since we are using Go, the yaml dependency is probably not that bad anymore, is it?
Makes the syntax much more convenient to write and it's still 100% compatible with json:
name: swf2_yaml type: git repo: https://github.com/radare/radare2-extras desc: "[r2-bin] SWF/Flash disassembler"
install:
- ./configure --prefix="${R2PM_PREFIX}" || exit 1
- cd libr/asm/p
- ${MAKE} clean
- ${MAKE} asm_swf.${LIBEXT} || exit 1
- mkdir -p "${R2PM_PLUGDIR}" || exit 1
- cp -f asm_swf.${LIBEXT} "${R2PM_PLUGDIR}" || exit 1
- cd ../../bin/p || exit 1
- ${MAKE} bin_swf.${LIBEXT} || exit 1
- echo cp -f bin_swf.${LIBEXT} "${R2PM_PLUGDIR}" || exit 1
- cp -f bin_swf.${LIBEXT} "${R2PM_PLUGDIR}" || exit 1
uninstall:
rm -f "${R2PM_PLUGDIR}"/swf You can view, comment on, or merge this pull request online at:
Commit Summary
Use YAML for packages File Changes
M r2pm.go (41) Patch Links:
https://github.com/radareorg/r2pm/pull/3.patch https://github.com/radareorg/r2pm/pull/3.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
This pr has nothing to do with Windows. I just think that writing yaml is much nicer than json.
Because this new r2pm currently only reads json, not shellscript.
Yeah i prefer yaml too
On 27 Jun 2018, at 15:25, Florian Märkl notifications@github.com wrote:
Because this new r2pm currently only reads json, not shellscript.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.
Since we are using Go, the yaml dependency is probably not that bad anymore, is it?
Makes the syntax much more convenient to write and it's still 100% compatible with json: