search

radareorg / r2pm

Radare2 cross platform package manager
GNU Lesser General Public License v3.0
34 stars 12 forks source link

Support for git tags/releases #72

Open XVilka opened 4 years ago

XVilka commented 4 years ago

See https://github.com/radareorg/radare2/pull/17178

Detailed description

When using r2 from non-git (release builds), installing packages can result in build problems. This PR aims to enable r2pm with the ability to pick the right commit from the tagged version from 3rd party repos if available.

Afaik this is done by r2ghidra-dec and r2dec-js, it may be good to define a different tag name than just the r2 version string, otherwise it will confuse users with the version of the decompiler and the version of the r2 required to build. Suggestion is to use r2- as prefix in the 3rd party repos.

Test plan

Get r2-4.4 and type the following command:

$ r2pm install r2ghidra-dec
qbarrand commented 4 years ago

Hi @XVilka, does the source.ref field of the new schema (when source.type=git) solve that problem?

XVilka commented 4 years ago

Yes, that would solve this 👍