search

radareorg / r2pm

Radare2 cross platform package manager
GNU Lesser General Public License v3.0
34 stars 12 forks source link

Handle the new manifest format #74

Closed qbarrand closed 4 years ago

qbarrand commented 4 years ago

Detailed description This MR is a first step towards the support of the new package format introduced earlier this year in the docs.

Test plan Run make tests.

Closing issues Although this does not close any issue per se, it contributes to #7 and #8.

codecov-commenter commented 4 years ago

Codecov Report

Merging #74 into master will increase coverage by 2.89%. The diff coverage is 61.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   23.11%   26.01%   +2.89%     
==========================================
  Files           9       15       +6     
  Lines         199      346     +147     
==========================================
+ Hits           46       90      +44     
- Misses        145      241      +96     
- Partials        8       15       +7
Impacted Files Coverage Δ
pkg/r2package/cmd.go 0.00% <0.00%> (ø)
pkg/r2package/filemgr.go 0.00% <0.00%> (ø)
pkg/r2package/info.go 0.00% <ø> (ø)
pkg/site/r2_nix.go 0.00% <0.00%> (ø)
pkg/r2package/installer.go 43.24% <43.24%> (ø)
pkg/r2package/manifest.go 96.55% <96.55%> (ø)
pkg/r2package/git.go 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ec9e9cf...c232ad9. Read the comment docs.

XVilka commented 4 years ago

Looks good to me, lets merge!