search

radareorg / r2retdec

RetDec plugin for Radare2
https://retdec.com/
MIT License
124 stars 24 forks source link

Update on radare2 api #35

Closed autquis closed 2 years ago

autquis commented 3 years ago

Hi! Check this commit. So, if you try to build retdec-r2plugin, you will see this error:

/home/xxxxxxx/.local/share/radare2/r2pm/git/retdec-r2plugin/include/r2plugin/r2cgen.h:14:10: fatal error: r_util/r_annotated_code.h: No such file or directory
   14 | #include <r_util/r_annotated_code.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

This happens when make tries to build target core_retdec.

This #34 will fix this. @xkubov

gogo2464 commented 3 years ago

This should be the priority. Currently retdec-r2plugin can not just be compiled.

gogo2464 commented 3 years ago

Fell free to assign me please.

s3rvac commented 3 years ago

Hello. We are aware of this issue, but we need to first resolve how to deal with the split of radare2 and Rizin (e.g. whether we should support both or just one of them). We are currently having discussions with maintainers of both projects. I am sorry for the inconvenience. Hopefully, everything will be resolved soon.

gogo2464 commented 3 years ago

@s3rvac will the next commits on your branch solve this issue or should I make a PR on this issue to solve it?

s3rvac commented 3 years ago

There is already a PR for that: #34. Like I said, we are aware of this issue, but we want to finish our discussions before we continue.

gogo2464 commented 3 years ago

Ok then do not assign me.