radareorg / r2retdec

RetDec plugin for Radare2
https://retdec.com/
MIT License
125 stars 24 forks source link

Build fails (Intel MacOS 13.4 / Xcode 14.3.1 / R2 5.8.8 macports) #49

Closed jac-cbi closed 1 year ago

jac-cbi commented 1 year ago

while running

r2pm -i r2retdec

I get

[ 99%] Linking CXX executable retdec-decompiler
[ 99%] Building CXX object src/r2plugin/CMakeFiles/core_retdec.dir/r2retdec.cpp.o
[ 99%] Built target retdec-decompiler
/Users/j/.local/share/radare2/r2pm/git/r2retdec/src/r2plugin/r2retdec.cpp:181:28: error: use of undeclared identifier 'R2_HOME_PLUGINS'
        auto plugdir = r_str_home(R2_HOME_PLUGINS);
                                  ^
1 error generated.
make[2]: *** [src/r2plugin/CMakeFiles/core_retdec.dir/r2retdec.cpp.o] Error 1
make[1]: *** [src/r2plugin/CMakeFiles/core_retdec.dir/all] Error 2
make: *** [all] Error 2

I'm new to this code, but it seems that it should be calling r_file_home(), and I can't seem to find where in the build it sets/creates/modifies/constructs R2_HOME_PLUGINS...

Any insight?

jac-cbi commented 1 year ago

Cc: @trufae

Is this how GitHub works? sorry to annoy, if not. used to git and email

trufae commented 1 year ago

Can you confirm if its fixed in master?

jac-cbi commented 1 year ago

That did it, thanks!

trufae commented 1 year ago

Cool. Ill cut a new release