URGENCY: High - Build error OS: FreeBSD AT: libr/anal/p/anal_avr.c ERR: unknown field 'consts' at 'cpu_models[]'

[unixfreaxjp]

• r2 version:

  heads/master-0-gffd8ecd

• Build environment:

  Final report:
  - PREFIX = /usr
  - HAVE_LIB_GMP = 0
  - HAVE_OPENSSL = 0
  - USE_CAPSTONE = 0
  - HAVE_FORK = 1
  - VERSION = 1.1.0-git
  - USE_LIB_ZIP = 0
  - USE_LIB_MAGIC = 0
  - DEBUGGER = 1
  - CC = gcc
  - USERCC = gcc
  - USEROSTYPE = bsd
  - LIBVERSION = 1.1.0-git
  - BUILD = i386-unknown-freebsd
  - HOST = i386-unknown-freebsd
  - TARGET = i386-unknown-freebsd

• Error occurred at:

  :
  CC anal_avr.c
  /libr/..//libr/anal/p/anal_avr.c:112: error: unknown field 'consts' specified in initializer
  /libr/..//libr/anal/p/anal_avr.c:120: error: unknown field 'consts' specified in initializer
  gmake[3]: *** [/TEST/radare/radare2/libr/../global.mk:42: /TEST/radare/radare2/libr/..//libr/anal/p/anal_avr.o] Error 1
  gmake[2]: *** [Makefile:83: anal] Error 2
  gmake[1]: *** [Makefile:31: all] Error 2
  gmake: *** [Makefile:51: all] Error 2
  :

• Build error log (full): https://github.com/unixfreaxjp/dev/blob/master/r2freebsdi686-3.md

• Linux version is unaffected:

  radare2 1.1.0-git 13124 @ linux-x86-32 git.1.0.2-173-g83d002c
  commit: 83d002cee5214675d67d5b48105a7278a81543c1 build: 2016-11-29

• The point of problem:

The usage of (undeclared/undefined) .consts for FreeBSD is not compatible in /libr/anal/p/anal_avr.c this function at CPU_MODEL cpu_models[], xref: (1) https://github.com/radare/radare2/blob/master/libr/anal/p/anal_avr.c#L112 and (2) https://github.com/radare/radare2/blob/master/libr/anal/p/anal_avr.c#L120 Code:

CPU_MODEL cpu_models[] = {
    {
        .model = "ATmega8", .pc = 13,
        .consts = {  // <=====================
            cpu_reg_common,
            cpu_memsize_common,
            cpu_pagesize_32,
            NULL
        }
    },
    { .model = "ATmega640",   .pc = 15,
        .consts = { // <=====================
            cpu_reg_common,
            cpu_memsize_m640_m1280m_m1281_m2560_m2561,
            cpu_pagesize_256,
            NULL
        },
    },
    { .model = "ATmega1280",  .pc = 16, .inherit = "ATmega640" },
    { .model = "ATmega1281",  .pc = 16, .inherit = "ATmega640" },
    { .model = "ATmega2560",  .pc = 17, .inherit = "ATmega640" },
    { .model = "ATmega2561",  .pc = 17, .inherit = "ATmega640" },
    { .model = "ATmega88",    .pc = 8,  .inherit = "ATmega8" },
    { .model = "unknown_avr", .pc = 8,  .inherit = "ATmega8" } // default AVR - ATmega8 forever!
//  CPU_MODEL_DECL ("ATmega168",   13, 512, 512),
};

@radare @XVilka @crowell @jvoisin @maijin

[radare]

cant reproduce

On 29 Nov 2016, at 11:51, unixfreaxjp notifications@github.com wrote:

r2 version: $ git describe --all --long heads/master-0-gffd8ecd build environment: Final report:

• PREFIX = /usr
• HAVE_LIB_GMP = 0
• HAVE_OPENSSL = 0
• USE_CAPSTONE = 0
• HAVE_FORK = 1
• VERSION = 1.1.0-git
• USE_LIB_ZIP = 0
• USE_LIB_MAGIC = 0
• DEBUGGER = 1
• CC = gcc
• USERCC = gcc
• USEROSTYPE = bsd
• LIBVERSION = 1.1.0-git
• BUILD = i386-unknown-freebsd
• HOST = i386-unknown-freebsd
• TARGET = i386-unknown-freebsd Error occurred at: : CC anal_avr.c /libr/..//libr/anal/p/anal_avr.c:112: error: unknown field 'consts' specified in initializer /libr/..//libr/anal/p/anal_avr.c:120: error: unknown field 'consts' specified in initializer gmake[3]: [/TEST/radare/radare2/libr/../global.mk:42: /TEST/radare/radare2/libr/..//libr/anal/p/anal_avr.o] Error 1 gmake[2]: [Makefile:83: anal] Error 2 gmake[1]: [Makefile:31: all] Error 2 gmake: [Makefile:51: all] Error 2 : Error log: https://github.com/unixfreaxjp/dev/blob/master/r2freebsdi686-3.md https://github.com/unixfreaxjp/dev/blob/master/r2freebsdi686-3.md Linux version is unaffected:

radare2 1.1.0-git 13124 @ linux-x86-32 git.1.0.2-173-g83d002c commit: 83d002cee5214675d67d5b48105a7278a81543c1 build: 2016-11-29 The point of problem: The usage of (undeclared/undefined) .consts for FreeBSD is not compatible in /libr/anal/p/anal_avr.c this function at CPU_MODEL cpu_models[], xref: (1) https://github.com/radare/radare2/blob/master/libr/anal/p/anal_avr.c#L112 https://github.com/radare/radare2/blob/master/libr/anal/p/anal_avr.c#L112 and (2) https://github.com/radare/radare2/blob/master/libr/anal/p/anal_avr.c#L120 https://github.com/radare/radare2/blob/master/libr/anal/p/anal_avr.c#L120 Code:

CPU_MODEL cpu_models[] = { { .model = "ATmega8", .pc = 13, .consts = { // <===================== cpu_reg_common, cpu_memsize_common, cpu_pagesize_32, NULL } }, { .model = "ATmega640", .pc = 15, .consts = { // <===================== cpu_reg_common, cpu_memsize_m640_m1280m_m1281_m2560_m2561, cpu_pagesize_256, NULL }, }, { .model = "ATmega1280", .pc = 16, .inherit = "ATmega640" }, { .model = "ATmega1281", .pc = 16, .inherit = "ATmega640" }, { .model = "ATmega2560", .pc = 17, .inherit = "ATmega640" }, { .model = "ATmega2561", .pc = 17, .inherit = "ATmega640" }, { .model = "ATmega88", .pc = 8, .inherit = "ATmega8" }, { .model = "unknown_avr", .pc = 8, .inherit = "ATmega8" } // default AVR - ATmega8 forever! // CPU_MODEL_DECL ("ATmega168", 13, 512, 512), }; @radare https://github.com/radare — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/radare/radare/issues/3, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lgLrWeUImQXWKdrtjrxQd-mi9cz9ks5rDAOngaJpZM4K-08R.

[Maijin]

@unixfreaxjp next time please open issue on https://github.com/radare/radare2 repo not "radare"

[unixfreaxjp]

@unixfreaxjp next time please open issue on https://github.com/radare/radare2 repo not "radare"

I am sorry, my bad. Copying to the correct place now.

[trufae]

can you try again?