radareorg / radare2-bindings

Bindings of the r2 api for Valabind and friends
GNU Lesser General Public License v3.0
131 stars 92 forks source link

python build regression in 1.0 release #142

Closed anthraxx closed 7 years ago

anthraxx commented 7 years ago

building with the radare2 1.0 release installed via:

./configure --prefix=/usr --enable=ctypes --enable=python
make

results in a regression:

r_core_wrap.cxx: In function ‘int RCore_project_open(RCore*, char*)’:
r_core_wrap.cxx:7430:40: error: too few arguments to function ‘int r_core_project_open(RCore*, const char*, bool)’
   return r_core_project_open(self, file);
                                        ^
In file included from r_core_wrap.cxx:3309:0:
/usr/include/libr/r_core.h:418:11: note: declared here
 R_API int r_core_project_open(RCore *core, const char *file, bool thready);
           ^~~~~~~~~~~~~~~~~~~

PS: even through it raises an error, the make call exists with 0, maybe this should be fixed too?

radare commented 7 years ago

Fixed in 1.0.1

On 9 Nov 2016, at 23:23, Levente Polyak notifications@github.com wrote:

building with the radare2 1.0 release installed via:

./configure --prefix=/usr --enable=ctypes --enable=python make results in a regression:

r_core_wrap.cxx: In function ‘int RCore_projectopen(RCore, char_)’: r_core_wrap.cxx:7430:40: error: too few arguments to function ‘int r_core_projectopen(RCore, const char_, bool)’ return r_core_project_open(self, file); ^ In file included from r_core_wrap.cxx:3309:0: /usr/include/libr/r_core.h:418:11: note: declared here R_API int r_core_project_open(RCore core, const char file, bool thready); ^~~~~~~ PS: even through it raises an error, the make call exists with 0, maybe this should be fixed too?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

anthraxx commented 7 years ago

@radare thx, confirming that it works